Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 12470006: mac content shell drt: Don't DLOG(FATAL) during font loading in debug builds (Closed)

Created:
7 years, 9 months ago by Nico
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

mac content shell drt: Don't DLOG(FATAL) during font loading in debug builds The problem was that `[[NSBundle mainBundle] bundlePath]` returned Content Shell.app's bundle in debug builds, but Content Shell.app/Contents/Versions/Content Shell Helper.app's bundle in debug builds. This is already handled in content/shell/paths_mac.mm, so use the code in there (and move the initialization for that code to happen before WebKitTestPlatformInitialize is called). BUG=179805 TEST=`echo compositing/absolute-position-changed-in-composited-layer.html | out/Debug/Content\ Shell.app/Contents/MacOS/Content\ Shell --dump-render-tree` passes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187402

Patch Set 1 #

Total comments: 1

Patch Set 2 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/shell/shell_main_delegate.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M content/shell/webkit_test_platform_support_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
First to lg wins!
7 years, 9 months ago (2013-03-11 22:05:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm does this also fix the http/tests/inspector tests timing out? https://codereview.chromium.org/12470006/diff/1/content/shell/shell_main_delegate.cc File content/shell/shell_main_delegate.cc (right): https://codereview.chromium.org/12470006/diff/1/content/shell/shell_main_delegate.cc#newcode98 ...
7 years, 9 months ago (2013-03-11 22:10:24 UTC) #2
Nico
On 2013/03/11 22:10:24, jochen wrote: > lgtm > > does this also fix the http/tests/inspector ...
7 years, 9 months ago (2013-03-11 22:16:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12470006/1
7 years, 9 months ago (2013-03-11 22:17:35 UTC) #4
Mark Mentovai
LGTM
7 years, 9 months ago (2013-03-11 22:17:56 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos_clang HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-11 22:28:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12470006/15001
7 years, 9 months ago (2013-03-11 22:28:32 UTC) #7
Nico
7 years, 9 months ago (2013-03-11 23:32:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r187402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698