Remove spammy NOTIMPLEMENTED call.

Remove spammy NOTIMPLEMENTED call from OmniboxViewGtk::ApplyCaretVisibility.


BUG=172302
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186468

[samarth, 2013-03-05 20:12:59]

Please take a look.

Thanks,
Samarth

[Elliot Glaysher, 2013-03-05 20:15:04]

lgtm

[commit-bot: I haz the power, 2013-03-05 20:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/12470003/1

[commit-bot: I haz the power, 2013-03-05 20:23:04]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-05 21:22:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/12470003/1

[commit-bot: I haz the power, 2013-03-05 21:29:13]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-05 22:37:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/12470003/1

[PaulePantert, 2013-03-06 09:07:37]

Hmm, I though in Gerrit one can also inline comment on commit messages.

Anyway, why not add the component and error message to the commit message too,
so people do not have to take a look at the bug report?

https://codereview.chromium.org/12470003/diff/1/chrome/browser/ui/gtk/omnibox...
File chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (left):

https://codereview.chromium.org/12470003/diff/1/chrome/browser/ui/gtk/omnibox...
chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc:431: NOTIMPLEMENTED();
I thought it was discussed in the bug report to just not show such messages for
release builds?

[commit-bot: I haz the power, 2013-03-06 13:06:18]

List of reviewers changed. pm.debian@googlemail.com did a drive-by without
LGTM'ing!

[samarth, 2013-03-06 18:32:08]

https://codereview.chromium.org/12470003/diff/1/chrome/browser/ui/gtk/omnibox...
File chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (left):

https://codereview.chromium.org/12470003/diff/1/chrome/browser/ui/gtk/omnibox...
chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc:431: NOTIMPLEMENTED();
On 2013/03/06 09:07:37, PaulePantert wrote:
> I thought it was discussed in the bug report to just not show such messages
for
> release builds?

We discussed changing NOTIMPLEMENTED so it doesn't log anything in release
builds.  That would have a much broader impact and is out of scope of this
change.

[commit-bot: I haz the power, 2013-03-06 18:32:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/12470003/1

[commit-bot: I haz the power, 2013-03-06 18:35:59]

Change committed as 186468