Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1246983002: Add "Ports" suffix to name to differentiate from nacl project (Closed)

Created:
5 years, 5 months ago by Sergiy Byelozyorov
Modified:
5 years, 5 months ago
Reviewers:
bradnelson, nodir, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Add "Ports" suffix to name to differentiate from NaCl project NOTRY=true NOTREECHECKS=true R=bradnelson@chromium.org, nodir@chromium.org BUG=497093 Committed: https://chromium.googlesource.com/external/naclports/+/410ab55b11909ecadfced8a7d02a0a09ace81feb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/project-config/project.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
Sergiy Byelozyorov
5 years, 5 months ago (2015-07-21 14:48:08 UTC) #1
nodir
lgtm. I will move to infra/config branch later.
5 years, 5 months ago (2015-07-21 15:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
5 years, 5 months ago (2015-07-21 15:32:09 UTC) #4
Sergiy Byelozyorov
On 2015/07/21 15:32:09, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 5 months ago (2015-07-21 15:32:48 UTC) #6
bradn
lgtm
5 years, 5 months ago (2015-07-21 17:12:01 UTC) #8
Sam Clegg
On 2015/07/21 15:20:26, nodir wrote: > lgtm. I will move to infra/config branch later. I ...
5 years, 5 months ago (2015-07-21 17:13:29 UTC) #9
bradn
agree with sam, seems odd to have a branch with alternate content.
5 years, 5 months ago (2015-07-21 17:17:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
5 years, 5 months ago (2015-07-21 17:17:56 UTC) #12
nodir
There were issues with storing these particular configs on master: a config in Chromium specified ...
5 years, 5 months ago (2015-07-21 17:24:26 UTC) #13
Sam Clegg
On 2015/07/21 17:24:26, nodir wrote: > There were issues with storing these particular configs on ...
5 years, 5 months ago (2015-07-21 17:26:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: naclports-linux-glibc-4 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-4/builds/929)
5 years, 5 months ago (2015-07-21 20:16:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
5 years, 5 months ago (2015-07-22 08:47:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
5 years, 5 months ago (2015-07-22 08:52:01 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 09:02:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/naclports/+/410ab55b11909ecadfced8...

Powered by Google App Engine
This is Rietveld 408576698