|
|
Created:
5 years, 5 months ago by Sergiy Byelozyorov Modified:
5 years, 5 months ago CC:
native-client-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/external/naclports.git@master Target Ref:
refs/heads/master Project:
naclports Visibility:
Public. |
DescriptionAdd "Ports" suffix to name to differentiate from NaCl project
NOTRY=true
NOTREECHECKS=true
R=bradnelson@chromium.org, nodir@chromium.org
BUG=497093
Committed: https://chromium.googlesource.com/external/naclports/+/410ab55b11909ecadfced8a7d02a0a09ace81feb
Patch Set 1 #
Messages
Total messages: 22 (8 generated)
lgtm. I will move to infra/config branch later.
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
The CQ bit was unchecked by sergiyb@chromium.org
On 2015/07/21 15:32:09, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1246983002/1 Brad, please review and CQ if it looks good to you.
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm
On 2015/07/21 15:20:26, nodir wrote: > lgtm. I will move to infra/config branch later. I think we would prefer not to have a dedicated branch if thats possible? (can we just use master?)
agree with sam, seems odd to have a branch with alternate content.
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
There were issues with storing these particular configs on master: a config in Chromium specified that the project is public. It got merged into a downstream internal project and it got exposed for a short period of time. ACLs should not live on master branch. You might not know that every Gerrit repo has "meta/config" ref that stores Gerrit ACLs, but you don't have to bother about it. Same applies to these configs.
On 2015/07/21 17:24:26, nodir wrote: > There were issues with storing these particular configs on master: a config in > Chromium specified that the project is public. It got merged into a downstream > internal project and it got exposed for a short period of time. > ACLs should not live on master branch. > > You might not know that every Gerrit repo has "meta/config" ref that stores > Gerrit ACLs, but you don't have to bother about it. Same applies to these > configs. OK.. if the infra team has decided that this is for sure the way you want us all to go, we won't stand in your way.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: naclports-linux-glibc-4 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-4/b...)
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246983002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/naclports/+/410ab55b11909ecadfced8... |