Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1246953003: Use thread-safe send when using Mojo. (Closed)

Created:
5 years, 5 months ago by jam
Modified:
5 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use thread-safe send when using Mojo. All the work was done in r325911 by morrita. It looks like when the change landed it was disabled though, so this change just turns it on. https://groups.google.com/a/chromium.org/d/msg/mojo-dev/gSidpDqtUFE/TY5qeUlD-mIJ has more timing, but the summary is that this makes MojoChannelPerfTest.ChannelProxyPingPong faster by 15% on Windows and roughly 40% on Linux. In total, ChannelProxyPingPong is faster using Mojo compared to Chrome IPC by roughly 70% on Windows and on Linux it's about the same or slightly faster. BUG=472113 Committed: https://crrev.com/527a6e1b6bdf00a4d8cb020914067612b6ecde99 Cr-Commit-Position: refs/heads/master@{#340216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 5 months ago (2015-07-23 21:56:17 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 5 months ago (2015-07-23 21:57:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1246953003/1
5 years, 5 months ago (2015-07-23 23:14:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 23:52:51 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 23:54:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/527a6e1b6bdf00a4d8cb020914067612b6ecde99
Cr-Commit-Position: refs/heads/master@{#340216}

Powered by Google App Engine
This is Rietveld 408576698