content/public/common/manifest.cc - Issue 1246953002: content: make theme_color more resilient to casting issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/manifest.cc

Issue 1246953002: content: make theme_color more resilient to casting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/manifest.cc

diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc

index ed19c470073b435008580c28e83da985666b65bb..53eae83a9b45cf618819b94ce366ac319c026b2a 100644

--- a/content/public/common/manifest.cc

+++ b/content/public/common/manifest.cc

@@ -7,7 +7,8 @@

namespace content {

const double Manifest::Icon::kDefaultDensity = 1;

-const int64_t Manifest::kInvalidOrMissingThemeColor = -1;

+const int64_t Manifest::kInvalidOrMissingThemeColor =

+ static_cast<int64_t>(std::numeric_limits<int32_t>::max()) + 1;

const size_t Manifest::kMaxIPCStringLength = 4 * 1024;

Manifest::Icon::Icon()

« no previous file with comments | « no previous file | content/renderer/manifest/manifest_parser.cc » ('j') | content/renderer/manifest/manifest_parser.cc » ('J')