Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: content/public/common/manifest.cc

Issue 1246953002: content: make theme_color more resilient to casting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.cc
diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc
index ed19c470073b435008580c28e83da985666b65bb..53eae83a9b45cf618819b94ce366ac319c026b2a 100644
--- a/content/public/common/manifest.cc
+++ b/content/public/common/manifest.cc
@@ -7,7 +7,8 @@
namespace content {
const double Manifest::Icon::kDefaultDensity = 1;
-const int64_t Manifest::kInvalidOrMissingThemeColor = -1;
+const int64_t Manifest::kInvalidOrMissingThemeColor =
+ static_cast<int64_t>(std::numeric_limits<int32_t>::max()) + 1;
Avi (use Gerrit) 2015/08/07 14:48:08 I'm having trouble wrapping my brain around this.
Lalit Maganti 2015/08/07 14:54:15 Have added a comment in the new patch.
const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
Manifest::Icon::Icon()
« no previous file with comments | « no previous file | content/renderer/manifest/manifest_parser.cc » ('j') | content/renderer/manifest/manifest_parser_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698