Remove unnecessary coupling between Promise tests and Object.observe

test/mjsunit/es6/promises.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11 matching lines @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --harmony-tostring
 
 // Make sure we don't rely on functions patchable by monkeys.
 var call = Function.prototype.call.call.bind(Function.prototype.call)
-var observe = Object.observe;
 var getOwnPropertyNames = Object.getOwnPropertyNames;
 var defineProperty = Object.defineProperty;
 var numberPrototype = Number.prototype;
 var symbolIterator = Symbol.iterator;
 
 
 (function() {
   // Test before clearing global (fails otherwise)
   assertEquals("[object Promise]",
       Object.prototype.toString.call(new Promise(function() {})));
@@ skipping 38 matching lines @@
   if (b) {
     print(s, "succeeded")
   } else {
     %AbortJS(s + " FAILED!")  // Simply throwing here will have no effect.
   }
   --asyncAssertsExpected
 }
 
 function assertAsyncDone(iteration) {
   var iteration = iteration || 0
-  var dummy = {}
-  observe(dummy,
+  Promise.resolve().then(

[rossberg, 2015/07/21 10:25:37]

Some of the tests now become a bit circular (relying on the correctness of
Promise.resolve/then to test the correctness of Promise.resolve/then). But I
don't have a better idea either.

[adamk, 2015/07/21 16:18:08]

I could switch them all to use %EnqueueMicrotask, if you'd prefer.

[rossberg, 2015/07/21 16:28:43]

Aw, of course. For some reason I though that can't be done, but I don't know
what I was thinking. :\  Please do.

     function() {
       if (asyncAssertsExpected === 0)
         assertAsync(true, "all")
       else if (iteration > 10)  // Shouldn't take more.
         assertAsync(false, "all")
       else
         assertAsyncDone(iteration + 1)
     }
   )
-  dummy.dummy = dummy
 }
 
 
 (function() {
   assertThrows(function() { Promise(function() {}) }, TypeError)
 })();
 
 (function() {
   assertTrue(new Promise(function() {}) instanceof Promise)
 })();
@@ skipping 915 matching lines @@
   Promise.all([11, Promise.accept(12), 13, MyPromise.accept(14), 15, 16])
   assertTrue(log === "nx14n", "subclass/all/arg")
 
   log = ""
   MyPromise.all([21, Promise.accept(22), 23, MyPromise.accept(24), 25, 26])
   assertTrue(log === "nx24nnx21nnx23nnnx25nnx26n", "subclass/all/self")
 })();
 
 
 assertAsyncDone()