Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1246933002: Remove unnecessary coupling between Promise tests and Object.observe (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary coupling between Promise tests and Object.observe Many mjsunit tests (as well as the promises-aplus adapter scripts) were using Object.observe simply for microtask-enqueueing purposes. Replaced such uses with %EnqueueMicrotask. Committed: https://crrev.com/4b8200078a9d1d9ec5bab268d0aff6453b47ddcc Cr-Commit-Position: refs/heads/master@{#29779}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use %EnqueueMicrotask #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -98 lines) Patch
M test/mjsunit/es6/debug-promises/events.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-all.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-by-default-reject-handler.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-all.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-late.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-all.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-by-default-reject-handler.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-all.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 2 chunks +9 lines, -14 lines 0 comments Download
M test/promises-aplus/lib/global.js View 1 2 chunks +2 lines, -11 lines 0 comments Download
M test/promises-aplus/lib/mocha.js View 1 4 chunks +4 lines, -13 lines 0 comments Download
M test/promises-aplus/testcfg.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
adamk
5 years, 5 months ago (2015-07-21 03:42:35 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( Some of the tests now become a ...
5 years, 5 months ago (2015-07-21 10:25:38 UTC) #3
adamk
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 10:25:37, rossberg wrote: > Some of ...
5 years, 5 months ago (2015-07-21 16:18:09 UTC) #4
rossberg
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 16:18:08, adamk wrote: > On 2015/07/21 ...
5 years, 5 months ago (2015-07-21 16:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246933002/20001
5 years, 5 months ago (2015-07-21 16:49:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 17:17:02 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:17:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b8200078a9d1d9ec5bab268d0aff6453b47ddcc
Cr-Commit-Position: refs/heads/master@{#29779}

Powered by Google App Engine
This is Rietveld 408576698