Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1246923003: Files.app: Stop to use autogen IDs of TreeItems to identify tree items. (Closed)

Created:
5 years, 5 months ago by hirono
Modified:
5 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dhaddock1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Stop to use autogen IDs of TreeItems to identify tree items. The IDs are generated by counter, so sometime different IDs were assigned to the items and it causes flakiness of browser tests. BUG=512669 TEST=None Committed: https://crrev.com/e95aca9224bb05f69ec9e695b52b49ca143672a1 Cr-Commit-Position: refs/heads/master@{#339848}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -22 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/test_util.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/keyboard_operations.js View 6 chunks +51 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 5 months ago (2015-07-22 07:49:49 UTC) #2
fukino
LGTM! Thanks!
5 years, 5 months ago (2015-07-22 07:55:02 UTC) #3
hirono
On 2015/07/22 07:55:02, fukino wrote: > LGTM! Thanks! Thanks!
5 years, 5 months ago (2015-07-22 07:55:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246923003/20001
5 years, 5 months ago (2015-07-22 07:55:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 08:38:22 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 08:39:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e95aca9224bb05f69ec9e695b52b49ca143672a1
Cr-Commit-Position: refs/heads/master@{#339848}

Powered by Google App Engine
This is Rietveld 408576698