Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1246923002: Merge AccessibilityTabSwitcherTest into OverviewListLayoutTest. (Closed)

Created:
5 years, 5 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge AccessibilityTabSwitcherTest into OverviewListLayoutTest. These files both test the accessibility tab switcher. This moves testObservesTitleChanges() from AccessibilityTabSwitcherTest into OverviewListLayoutTest, and deletes AccessibilityTabSwitcherTest.testCanEnterAndLeaveSwitcher() since equivalent tests already exist in OverviewListLayoutTest. BUG=505040 Committed: https://crrev.com/2bed618af46eda83e31c63202859f4b64bbca5b4 Cr-Commit-Position: refs/heads/master@{#339682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -106 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java View 5 chunks +55 lines, -0 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabSwitcherTest.java View 1 chunk +0 lines, -106 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
newt (away)
PTAL
5 years, 5 months ago (2015-07-21 02:59:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246923002/1
5 years, 5 months ago (2015-07-21 03:00:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 03:28:55 UTC) #6
gone
Good to know our inconsistent naming schemes make even our tests obtuse. lgtm
5 years, 5 months ago (2015-07-21 17:11:08 UTC) #7
newt (away)
On 2015/07/21 17:11:08, dfalcantara wrote: > Good to know our inconsistent naming schemes make even ...
5 years, 5 months ago (2015-07-21 17:19:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246923002/1
5 years, 5 months ago (2015-07-21 17:20:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 17:27:27 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:28:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bed618af46eda83e31c63202859f4b64bbca5b4
Cr-Commit-Position: refs/heads/master@{#339682}

Powered by Google App Engine
This is Rietveld 408576698