Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 12469003: Fixed a few warnings (Closed)

Created:
7 years, 9 months ago by sugoi1
Modified:
7 years, 9 months ago
Reviewers:
bungeman, bsalomon, sugoi, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixed a few warnings Removed a few warnings from the Skia code. Committed: https://code.google.com/p/skia/source/detail?r=7996

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M src/gpu/GrDrawState.h View 1 chunk +1 line, -1 line 2 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +0 lines, -11 lines 1 comment Download
M src/ports/SkFontHost_FreeType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
sugoi
https://codereview.chromium.org/12469003/diff/1/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/12469003/diff/1/src/gpu/GrDrawState.h#newcode426 src/gpu/GrDrawState.h:426: AutoColorRestore() : fDrawState(NULL), fOldColor(0) {} Added this to remove ...
7 years, 9 months ago (2013-03-05 20:16:45 UTC) #1
bsalomon
lgtm for the GPU change but I think someone else (ben? mike?) should review the ...
7 years, 9 months ago (2013-03-05 20:19:20 UTC) #2
sugoi
Adding bungeman as a reviewer for the FreeType part.
7 years, 9 months ago (2013-03-05 20:23:53 UTC) #3
reed1
lgtm
7 years, 9 months ago (2013-03-05 20:35:36 UTC) #4
sugoi1
7 years, 9 months ago (2013-03-05 20:40:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r7996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698