Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/gpu/effects/GrConvolutionEffect.h

Issue 12469002: Removed unused parameters (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/gpu/effects/GrConfigConversionEffect.cpp ('k') | src/gpu/effects/GrConvolutionEffect.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrConvolutionEffect_DEFINED 8 #ifndef GrConvolutionEffect_DEFINED
9 #define GrConvolutionEffect_DEFINED 9 #define GrConvolutionEffect_DEFINED
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 virtual ~GrConvolutionEffect(); 45 virtual ~GrConvolutionEffect();
46 46
47 const float* kernel() const { return fKernel; } 47 const float* kernel() const { return fKernel; }
48 48
49 static const char* Name() { return "Convolution"; } 49 static const char* Name() { return "Convolution"; }
50 50
51 typedef GrGLConvolutionEffect GLEffect; 51 typedef GrGLConvolutionEffect GLEffect;
52 52
53 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE; 53 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE;
54 54
55 virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags ) const { 55 virtual void getConstantColorComponents(GrColor*, uint32_t* validFlags) cons t {
56 // If the texture was opaque we could know that the output color if we k new the sum of the 56 // If the texture was opaque we could know that the output color if we k new the sum of the
57 // kernel values. 57 // kernel values.
58 *validFlags = 0; 58 *validFlags = 0;
59 } 59 }
60 60
61 enum { 61 enum {
62 // This was decided based on the min allowed value for the max texture 62 // This was decided based on the min allowed value for the max texture
63 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0 63 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0
64 // on a blur filter gives a kernel width of 25 while a sigma of 5.0 64 // on a blur filter gives a kernel width of 25 while a sigma of 5.0
65 // would exceed a 32 wide kernel. 65 // would exceed a 32 wide kernel.
(...skipping 17 matching lines...) Expand all
83 float gaussianSigma); 83 float gaussianSigma);
84 84
85 virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE; 85 virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE;
86 86
87 GR_DECLARE_EFFECT_TEST; 87 GR_DECLARE_EFFECT_TEST;
88 88
89 typedef Gr1DKernelEffect INHERITED; 89 typedef Gr1DKernelEffect INHERITED;
90 }; 90 };
91 91
92 #endif 92 #endif
OLDNEW
« no previous file with comments | « src/gpu/effects/GrConfigConversionEffect.cpp ('k') | src/gpu/effects/GrConvolutionEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698