Change the meaning of MobileSessionShutdownType's FIRST_LAUNCH_AFTER_UPGRADE bucket.

ios/chrome/browser/metrics/ios_stability_metrics_provider_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/metrics/ios_stability_metrics_provider.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/testing_pref_service.h"
@@ skipping 82 matching lines @@
 // least significant to most significant):
 //  - received memory warning;
 //  - crash log present;
 //  - uploaded crash reports in background;
 //  - last shutdown was clean;
 //  - first launch after upgrade.
 TEST_P(IOSStabilityMetricsProviderTest, ProvideStabilityMetrics) {
   const bool received_memory_warning = GetParam() % 2;
   const bool has_crash_logs = (GetParam() >> 1) % 2;
   const bool has_uploaded_crash_reports_in_background = (GetParam() >> 2) % 2;
-  const bool was_last_shutdown_clean = (GetParam() >> 3) % 2;
-  const bool is_first_launch_after_upgrade = (GetParam() >> 4) % 2;
+  const bool is_first_launch_after_upgrade = (GetParam() >> 3) % 2;
+  const bool was_last_shutdown_clean = (GetParam() >> 4) % 2;
 
   // Expected bucket for each possible value of GetParam().
   const MobileSessionShutdownType expected_buckets[] = {
       SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_NO_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_WITH_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING,
       SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING,
-      // If wasLastShutdownClean is true, the memory warning and crash log don't
-      // matter.
+      // If firstLaunchAfterUpgrade is true, it is not possible to determine the
+      // real reason of the crash, so the memory warning and crash log flags
+      // don't matter.
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
+      // If wasLastShutdownClean is true, the other flags don't matter.
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
+      SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
       SHUTDOWN_IN_BACKGROUND,
-      // If firstLaunchAfterUpgrade is true, the other flags don't matter.
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
-      FIRST_LAUNCH_AFTER_UPGRADE,
   };
 
   // Setup the MetricsService.
   local_state_.SetBoolean(metrics::prefs::kStabilityExitedCleanly,
                           was_last_shutdown_clean);
   metrics_state_ = metrics::MetricsStateManager::Create(
       &local_state_, base::Bind(&IsMetricsReportingEnabled),
       metrics::MetricsStateManager::StoreClientInfoCallback(),
       metrics::MetricsStateManager::LoadClientInfoCallback());
   metrics_service_.reset(new metrics::MetricsService(
@@ skipping 19 matching lines @@
   // Now call the method under test and verify exactly one sample is written to
   // the expected bucket.
   metrics_provider_->ProvideInitialStabilityMetrics(nullptr);
   histogram_tester.ExpectUniqueSample("Stability.MobileSessionShutdownType",
                                       expected_buckets[GetParam()], 1);
 }
 
 INSTANTIATE_TEST_CASE_P(/* No InstantiationName */,
                         IOSStabilityMetricsProviderTest,
                         testing::Range(0, 32));