Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1246833004: bookmarks: Remove a bunch of unnecessary BookmarkModelFactory::GetForProfile() calls. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Remove a bunch of unnecessary BookmarkModelFactory::GetForProfile() calls. Instead of making a series of calls to it, keep the model in variable and reuse it. BUG=None TEST=unit_tests --gtest_filter=BookmarkBarViewTest.* R=sky@chromium.org Committed: https://crrev.com/ec4bd88bad1c19db9b7c311475608a8d7a2e1718 Cr-Commit-Position: refs/heads/master@{#339740}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -38 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 1 6 chunks +23 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
5 years, 5 months ago (2015-07-21 15:00:08 UTC) #1
sky
LGTM
5 years, 5 months ago (2015-07-21 19:31:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246833004/20001
5 years, 5 months ago (2015-07-21 20:05:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 20:36:21 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:38:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec4bd88bad1c19db9b7c311475608a8d7a2e1718
Cr-Commit-Position: refs/heads/master@{#339740}

Powered by Google App Engine
This is Rietveld 408576698