Issue 12468: Merge code review fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12468: Merge code review fixes. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Merge code review fixes.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -93 lines)			Patch
M	src/SConscript	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ast.h	View	16 chunks	+30 lines, -26 lines	0 comments	Download
M	src/jsregexp.h	View	13 chunks	+40 lines, -44 lines	0 comments	Download
M	src/jsregexp.cc	View	4 chunks	+8 lines, -8 lines	1 comment	Download
M	src/jsregexp-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years ago (2008-11-26 07:33:58 UTC) #2

LGTM.  Thanks!

http://codereview.chromium.org/12468/diff/1/5
File src/jsregexp.cc (right):

http://codereview.chromium.org/12468/diff/1/5#newcode2091
Line 2091: to() <= kRangeCanonicalizeMax) {
Align to() with from().

Expand Messages | Collapse Messages