Check that |gpu_channel_host_| is not NULL before passing it along.

Check that |gpu_channel_host_| is not NULL before passing it along.

This should move the investigation of bug 495185 closer to the root
cause.

BUG=495185
Committed: https://crrev.com/057435b69a0bdedab8039a663ce216735f9f1a70
Cr-Commit-Position: refs/heads/master@{#339721}

[sandersd (OOO until July 31), 2015-07-20 22:10:04]

sandersd@chromium.org changed reviewers:
+ posciak@chromium.org

[sandersd (OOO until July 31), 2015-07-20 22:11:22]

Patchset #1 (id:1) has been deleted

[Pawel Osciak, 2015-07-21 00:12:23]

lgtm

[Pawel Osciak, 2015-07-21 00:15:00]

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
content/renderer/render_thread_impl.cc:1430: }
Should we be checking gpu_channel_host again here?

[sandersd (OOO until July 31), 2015-07-21 00:35:02]

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
content/renderer/render_thread_impl.cc:1430: }
On 2015/07/21 00:15:00, Pawel Osciak wrote:
> Should we be checking gpu_channel_host again here?

Both WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext() and
ContextProviderCommandBuffer::Create() check for and then return NULL, so at the
very least the result is safe (and matches my expectations about correct
behavior).

[sandersd (OOO until July 31), 2015-07-21 00:36:29]

sandersd@chromium.org changed reviewers:
+ jochen@chromium.org

[sandersd (OOO until July 31), 2015-07-21 00:36:29]

jochen@chromium.org: Please review changes in content/renderer

[jochen (gone - plz use gerrit), 2015-07-21 14:12:58]

lgtm with comments addressed

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/media/...
File content/renderer/media/renderer_gpu_video_accelerator_factories.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/media/...
content/renderer/media/renderer_gpu_video_accelerator_factories.cc:62:
DCHECK(gpu_channel_host_.get());
did you mean to make this a CHECK()?

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
content/renderer/render_thread_impl.cc:1452: CHECK(gpu_channel_host.get());
please add a comment pointing at the crbug, and consider printing something when
you hit the CHECK(), e.g.

CHECK(gpu_channel_host.get()) << "No gpu_channel_host?? see crbug.com/495185";

[sandersd (OOO until July 31), 2015-07-21 17:29:57]

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/media/...
File content/renderer/media/renderer_gpu_video_accelerator_factories.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/media/...
content/renderer/media/renderer_gpu_video_accelerator_factories.cc:62:
DCHECK(gpu_channel_host_.get());
On 2015/07/21 14:12:58, jochen wrote:
> did you mean to make this a CHECK()?

I meant it more as documentation here.

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1246783003/diff/20001/content/renderer/render...
content/renderer/render_thread_impl.cc:1452: CHECK(gpu_channel_host.get());
On 2015/07/21 14:12:58, jochen wrote:
> please add a comment pointing at the crbug, and consider printing something
when
> you hit the CHECK(), e.g.
> 
> CHECK(gpu_channel_host.get()) << "No gpu_channel_host?? see crbug.com/495185";

Done.

[sandersd (OOO until July 31), 2015-07-21 17:30:53]

The CQ bit was checked by sandersd@chromium.org

[sandersd (OOO until July 31), 2015-07-21 17:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/1246783003/#ps40001
(title: "Add message.")

[commit-bot: I haz the power, 2015-07-21 17:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246783003/40001

[commit-bot: I haz the power, 2015-07-21 19:37:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-07-21 19:49:23]

Patchset 2 (id:??) landed as
https://crrev.com/057435b69a0bdedab8039a663ce216735f9f1a70
Cr-Commit-Position: refs/heads/master@{#339721}