Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Issue 1246783002: download_gold_plugin.py: Redirect stderr to /dev/null when calling gsutil. (Closed)

Created:
5 years, 5 months ago by pcc1
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

download_gold_plugin.py: Redirect stderr to /dev/null when calling gsutil. When called from a bot, runhooks' stdin will be redirected to /dev/null. The hack we use in update.py that redirects stdin to stderr causes a read-only /dev/null to eventually appear as gsutil's stderr here, which causes it to blow up for an unknown reason. To avoid this problem, open a writable /dev/null and redirect unconditionally here. This prevents command line users from seeing gsutil's output, but at least the thing runs. BUG=453195 R=thakis@chromium.org Committed: https://crrev.com/83a9be53371d0bc5a1084e2162cb28b2d073433e Cr-Commit-Position: refs/heads/master@{#339542}

Patch Set 1 #

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/download_gold_plugin.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
5 years, 5 months ago (2015-07-20 19:49:58 UTC) #1
Nico
lgtm Maybe you can add some "remove this once crbug.com/494442 is fixed" type of comment ...
5 years, 5 months ago (2015-07-20 20:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246783002/20001
5 years, 5 months ago (2015-07-20 22:25:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-20 22:39:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 22:40:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83a9be53371d0bc5a1084e2162cb28b2d073433e
Cr-Commit-Position: refs/heads/master@{#339542}

Powered by Google App Engine
This is Rietveld 408576698