Move a subset of chrome/browser/chromeos/drive into components/drive

components/drive/BUILD.gn

Index: components/drive/BUILD.gn
diff --git a/components/drive/BUILD.gn b/components/drive/BUILD.gn
index f3f91c46b30e81f7c5aef7100a67dea762286f9e..dbf2da98460238e063ce3595c3a3db04bd7910c5 100644
--- a/components/drive/BUILD.gn
+++ b/components/drive/BUILD.gn
@@ -14,10 +14,18 @@ source_set("drive") {
     "drive_notification_manager.cc",
     "drive_notification_manager.h",
     "drive_notification_observer.h",
+    "drive_pref_names.cc",
+    "drive_pref_names.h",
     "drive_uploader.cc",
     "drive_uploader.h",
     "event_logger.cc",
     "event_logger.h",
+    "file_change.cc",
+    "file_change.h",
+    "file_errors.cc",
+    "file_errors.h",
+    "local_file_reader.cc",
+    "local_file_reader.h",
     "service/drive_api_service.cc",
     "service/drive_api_service.h",
     "service/drive_service_interface.cc",
@@ -44,7 +52,7 @@ source_set("drive") {
 }
 
 proto_library("proto") {
-  visibility = [ ":drive" ]
+  visibility = [ ":*" ]

[hashimoto, 2015/07/23 06:01:15]

Why do we need to maintain this line?

[Łukasz Anforowicz, 2015/07/27 17:53:27]

This means that BUILD.gn targets from outside of components/drive directory
cannot directly depend on components/drive:proto.  Maybe this is not really
needed (i.e. the :proto target is not really "internal" to components/drive)? 
WDYT?

[hashimoto, 2015/07/29 02:07:08]

This "visibility" line was added by you in
https://codereview.chromium.org/1243853002/ (sorry, I didn't notice it in the
review and I'm not sure why you added it).
If you see no reason to maintain this line, please remove it.

[Łukasz Anforowicz, 2015/08/03 21:30:48]

Done.  I don't see a compelling reason to keep this line.

   sources = [
     "drive.proto",
   ]
@@ -53,6 +61,8 @@ proto_library("proto") {
 source_set("test_support") {
   testonly = true
   sources = [
+    "drive_test_util.cc",
+    "drive_test_util.h",
     "service/dummy_drive_service.cc",
     "service/dummy_drive_service.h",
     "service/fake_drive_service.cc",
@@ -62,6 +72,7 @@ source_set("test_support") {
   ]
   deps = [
     ":drive",
+    ":proto",
     "//base:base",
     "//google_apis:google_apis",
     "//net:net",