Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 1246743003: mac: Switch the default build configuration to use the 10.10 SDK. (Closed)

Created:
5 years, 5 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Nico, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Switch the default build configuration to use the 10.10 SDK. This change is intended to be temporary. The goal is to release a Canary compiled against the 10.10 SDK, and then to revert this CL. BUG=463170 Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 Cr-Commit-Position: refs/heads/master@{#340992}

Patch Set 1 #

Patch Set 2 : Add changes to GN. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
erikchen
thakis: Please review. The current plan is to land this on Wednesday morning, so that ...
5 years, 5 months ago (2015-07-20 18:28:28 UTC) #2
Nico
Nice! Even though it's just temporary, you should make the same change in build/config/mac/mac_sdk.gni in ...
5 years, 5 months ago (2015-07-20 18:29:46 UTC) #3
erikchen
On 2015/07/20 18:29:46, Nico wrote: > Nice! Even though it's just temporary, you should make ...
5 years, 5 months ago (2015-07-20 19:01:20 UTC) #4
Nico
lgtm
5 years, 5 months ago (2015-07-20 19:01:49 UTC) #5
Nico
Also, you should probably send an announcement to chromium-dev saying something like "mac: we'll require ...
5 years, 5 months ago (2015-07-20 19:07:04 UTC) #6
erikchen
On 2015/07/20 19:07:04, Nico wrote: > Also, you should probably send an announcement to chromium-dev ...
5 years, 5 months ago (2015-07-20 20:11:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1246743003/20001
5 years, 4 months ago (2015-07-29 20:24:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 21:37:32 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 Cr-Commit-Position: refs/heads/master@{#340992}
5 years, 4 months ago (2015-07-29 21:38:44 UTC) #11
erikchen
5 years, 4 months ago (2015-07-29 22:39:50 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1254123003/ by erikchen@chromium.org.

The reason for reverting is: Causes gclient runhooks to fail on bots that don't
have the 10.10 SDK (even though they don't need to compile).

Powered by Google App Engine
This is Rietveld 408576698