Remove notifications from PrintPreviewDialogController.

Remove notifications from PrintPreviewDialogController.

BUG=170921
TEST=everything still works

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243252

[Lei Zhang, 2014-01-06 20:29:21]

lgtm with a nit below.

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
chrome/browser/printing/print_preview_dialog_controller.cc:390:
STLDeleteElements(&preview_operations_);
Isn't this handling a DCHECK failure, which is something the chromium style
guide says not to do?

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
File chrome/browser/printing/print_preview_dialog_controller.h (right):

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
chrome/browser/printing/print_preview_dialog_controller.h:93:
std::vector<Operation*> preview_operations_;
|preview_operations_| should be small, so removing the std::map should be fine.

[Avi (use Gerrit), 2014-01-06 21:34:05]

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
chrome/browser/printing/print_preview_dialog_controller.cc:390:
STLDeleteElements(&preview_operations_);
On 2014/01/06 20:29:22, Lei Zhang wrote:
> Isn't this handling a DCHECK failure, which is something the chromium style
> guide says not to do?

True. Removed.

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
File chrome/browser/printing/print_preview_dialog_controller.h (right):

https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
chrome/browser/printing/print_preview_dialog_controller.h:93:
std::vector<Operation*> preview_operations_;
On 2014/01/06 20:29:22, Lei Zhang wrote:
> |preview_operations_| should be small, so removing the std::map should be
fine.

Yep, that's what I figured. The problem is that there is no better data
structure. Even with the map we were looking things up by initiator all the
time, which even with the map was a linear search.

[commit-bot: I haz the power, 2014-01-06 21:34:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/124673002/230001

[commit-bot: I haz the power, 2014-01-07 10:59:41]

Change committed as 243252

[skyline999boy, 2014-04-26 12:00:14]

On 2014/01/06 20:29:21, Lei Zhang wrote:
> lgtm with a nit below.
> 
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> File chrome/browser/printing/print_preview_dialog_controller.cc (right):
> 
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> chrome/browser/printing/print_preview_dialog_controller.cc:390:
> STLDeleteElements(&preview_operations_);
> Isn't this handling a DCHECK failure, which is something the chromium style
> guide says not to do?
> 
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> File chrome/browser/printing/print_preview_dialog_controller.h (right):
> 
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> chrome/browser/printing/print_preview_dialog_controller.h:93:
> std::vector<Operation*> preview_operations_;
> |preview_operations_| should be small, so removing the std::map should be
fine.

[skyline999boy, 2014-04-26 12:00:32]

On 2014/04/26 12:00:14, skyline999boy wrote:
> On 2014/01/06 20:29:21, Lei Zhang wrote:
> > lgtm with a nit below.
> > 
> >
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> > File chrome/browser/printing/print_preview_dialog_controller.cc (right):
> > 
> >
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> > chrome/browser/printing/print_preview_dialog_controller.cc:390:
> > STLDeleteElements(&preview_operations_);
> > Isn't this handling a DCHECK failure, which is something the chromium style
> > guide says not to do?
> > 
> >
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> > File chrome/browser/printing/print_preview_dialog_controller.h (right):
> > 
> >
>
https://codereview.chromium.org/124673002/diff/110001/chrome/browser/printing...
> > chrome/browser/printing/print_preview_dialog_controller.h:93:
> > std::vector<Operation*> preview_operations_;
> > |preview_operations_| should be small, so removing the std::map should be
> fine.