Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: src/d8.cc

Issue 1246643002: Fix stack trace printing in d8 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 06499ef6dd39efd2c45962a907277f3013b4a6a0..a56d029f5a5fb2fedb3fb568578ca9b90f53bada 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -917,7 +917,8 @@ void Shell::ReportException(Isolate* isolate, v8::TryCatch* try_catch) {
printf("\n");
Local<Value> stack_trace_string;
if (try_catch->StackTrace(isolate->GetCurrentContext())
- .ToLocal(&stack_trace_string)) {
+ .ToLocal(&stack_trace_string) &&
+ stack_trace_string->IsString()) {
v8::String::Utf8Value stack_trace(
Local<String>::Cast(stack_trace_string));
printf("%s\n", ToCString(stack_trace));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698