Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: src/global-handles.h

Issue 1246603002: Don't run the second pass of the pending phantom callbacks if the heap has been torn down. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | src/global-handles.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/global-handles.h
diff --git a/src/global-handles.h b/src/global-handles.h
index 0ee8c20a375adaea6803c11034686b08d806f9d8..1b8994d4765b2fc1cf4e39527411c1c61e4b306f 100644
--- a/src/global-handles.h
+++ b/src/global-handles.h
@@ -304,6 +304,8 @@ class GlobalHandles {
class NodeIterator;
class PendingPhantomCallbacksSecondPassTask;
+ void ClearPhantomCallbacksTask(PendingPhantomCallbacksSecondPassTask* task);
+
Isolate* isolate_;
// Field always containing the number of handles to global objects.
@@ -337,6 +339,11 @@ class GlobalHandles {
List<PendingPhantomCallback> pending_phantom_callbacks_;
+ // Scheduled task that runs the second pass of the phantom callbacks.
+ // We keep this pointer to send a notification when the heap is being torn
+ // down.
+ PendingPhantomCallbacksSecondPassTask* phantom_callbacks_task_;
+
friend class Isolate;
DISALLOW_COPY_AND_ASSIGN(GlobalHandles);
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | src/global-handles.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698