Don't run the second pass of the pending phantom callbacks if the heap has been torn down.

Don't run the second pass of the pending phantom callbacks if the heap has been torn down.

R=jochen@chromium.org
BUG=511204
LOG=y

Committed: https://crrev.com/df2d1ef979bfb11e7001b238aecadb88791bc8d9
Cr-Commit-Position: refs/heads/master@{#29759}

[epertoso, 2015-07-20 09:56:41]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 09:56:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246603002/1

[jochen (gone - plz use gerrit), 2015-07-20 09:58:17]

https://codereview.chromium.org/1246603002/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/1246603002/diff/1/src/global-handles.cc#newco...
src/global-handles.cc:873: reinterpret_cast<v8::Isolate*>(isolate()),
phantom_callbacks_task_);
there could be more than one task, no?

maybe it's worthwhile to pull out a base class of tasks that run on the
foreground thread, and have a set<> of pending tasks e.g. on Heap or on Isolate

[commit-bot: I haz the power, 2015-07-20 10:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 10:00:59]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4310)

[epertoso, 2015-07-20 13:14:21]

PTAL.

https://codereview.chromium.org/1246603002/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/1246603002/diff/1/src/global-handles.cc#newco...
src/global-handles.cc:873: reinterpret_cast<v8::Isolate*>(isolate()),
phantom_callbacks_task_);
On 2015/07/20 at 09:58:17, jochen wrote:
> there could be more than one task, no?
> 
> maybe it's worthwhile to pull out a base class of tasks that run on the
foreground thread, and have a set<> of pending tasks e.g. on Heap or on Isolate

Done.

[jochen (gone - plz use gerrit), 2015-07-20 13:37:20]

lgtm

https://codereview.chromium.org/1246603002/diff/20001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/1246603002/diff/20001/src/isolate.h#newcode9
src/isolate.h:9: #include <set>
nit. empty line after this one

[epertoso, 2015-07-20 13:40:21]

https://codereview.chromium.org/1246603002/diff/20001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/1246603002/diff/20001/src/isolate.h#newcode9
src/isolate.h:9: #include <set>
On 2015/07/20 at 13:37:20, jochen wrote:
> nit. empty line after this one

Done.

[epertoso, 2015-07-20 14:38:52]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2015-07-20 14:38:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1246603002/#ps60001
(title: "update")

[commit-bot: I haz the power, 2015-07-20 14:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246603002/60001

[commit-bot: I haz the power, 2015-07-20 15:03:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-20 15:04:13]

Patchset 4 (id:??) landed as
https://crrev.com/df2d1ef979bfb11e7001b238aecadb88791bc8d9
Cr-Commit-Position: refs/heads/master@{#29759}