Issue 12466008: PDF: add support for named destinations

Issue 12466008: PDF: add support for named destinations (Closed)

Created:
7 years, 9 months ago by epoger

Modified:
7 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

PDF: add support for named destinations Imported from https://codereview.appspot.com/7374052/ on behalf of dml@google.com Committed: https://code.google.com/p/skia/source/detail?r=8000

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+338 lines, -39 lines)			Patch
A	gm/internal_links.cpp	View	1 chunk	+77 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkAnnotation.h	View	3 chunks	+39 lines, -0 lines	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	5 chunks	+20 lines, -2 lines	0 comments	Download
M	src/core/SkAnnotation.cpp	View	2 chunks	+35 lines, -7 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	7 chunks	+97 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFPage.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pipe/SkGPipePriv.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pipe/SkGPipeRead.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	4 chunks	+6 lines, -0 lines	0 comments	Download
M	tests/AnnotationTest.cpp	View	2 chunks	+38 lines, -15 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

epoger

I have launched 2 trybots: tools/submit_try patch --bot Skia_Linux_NoGPU_Debug_32 Skia_Shuttle_Win7_Intel_Float_Debug_64 -r 7989 They haven't started ...

7 years, 9 months ago (2013-03-05 19:21:26 UTC) #1

epoger

So far, so good: http://70.32.156.53:10117/builders/Skia_Linux_NoGPU_Debug_32_Trybot/builds/85 succeeded except for its CompareGMs step, which exhibited the same ...

7 years, 9 months ago (2013-03-05 19:44:13 UTC) #2

epoger

The http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_Debug_64_Trybot/builds/23 trybot succeeded! Committing now...

7 years, 9 months ago (2013-03-06 00:04:56 UTC) #3

epoger

Committed patchset #1 manually as r8000 (presubmit successful).

7 years, 9 months ago (2013-03-06 00:05:17 UTC) #4

epoger

On 2013/03/06 00:05:17, epoger wrote: > Committed patchset #1 manually as r8000 (presubmit successful). Sigh... ...

7 years, 9 months ago (2013-03-06 00:49:15 UTC) #5

epoger

On 2013/03/06 00:49:15, epoger wrote: > On 2013/03/06 00:05:17, epoger wrote: > > Committed patchset ...

7 years, 9 months ago (2013-03-06 00:59:29 UTC) #6

David Lattimore

I've uploaded a new patch set at https://codereview.appspot.com/7374052/ that fixes the two errors I could ...

7 years, 9 months ago (2013-03-06 02:55:11 UTC) #7

epoger

7 years, 9 months ago (2013-03-06 15:56:14 UTC) #8

Message was sent while issue was closed.

On 2013/03/06 02:55:11, dml wrote:
> I've uploaded a new patch set at https://codereview.appspot.com/7374052/ that
> fixes the two errors I could see. I also found that the links I was generating
> don't work with all viewers, so I included a fix for that (just changed an
> SkPDFString to an SkPDFName).

I copied the above patch to new https://codereview.chromium.org/12533009/ . 
Closing this codereview in favor of that one...

Expand Messages | Collapse Messages