Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246513002: Fix element enumeration on String wrappers with dictionary elements (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix element enumeration on String wrappers with dictionary elements BUG=chromium:510426 LOG=n Committed: https://crrev.com/e6cb6bb6b781aaa6a4025d5991ff40ab2154564c Cr-Commit-Position: refs/heads/master@{#29745}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/objects.cc View 2 chunks +2 lines, -2 lines 2 comments Download
A + test/mjsunit/regress/regress-crbug-510426.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
https://codereview.chromium.org/1246513002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1246513002/diff/1/src/objects.cc#newcode13033 src/objects.cc:13033: dictionary->CopyKeysTo(storage, counter, filter, This should always be zero anyway, ...
5 years, 5 months ago (2015-07-17 18:10:34 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1246513002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1246513002/diff/1/src/objects.cc#newcode13033 src/objects.cc:13033: dictionary->CopyKeysTo(storage, counter, filter, On 2015/07/17 18:10:34, adamk wrote: ...
5 years, 5 months ago (2015-07-20 08:12:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246513002/1
5 years, 5 months ago (2015-07-20 08:17:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 09:00:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 09:01:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6cb6bb6b781aaa6a4025d5991ff40ab2154564c
Cr-Commit-Position: refs/heads/master@{#29745}

Powered by Google App Engine
This is Rietveld 408576698