Refactor libjingle.gyp:

Refactor libjingle.gyp:

* Move code out of libjingle_p2p and libjingle_peerconnection into the libjingle lib.
* Update gyp files that previously depended on libjingle_p2p to depend on libjingle.
* Only the constant files are left in the extra libs (which is why they exist).
* Move the webrtc code out into a separate target.

[tommi (sloooow) - chröme, 2013-03-05 17:50:53]

ronghuawu: Main reviewer.
sergeyu: Owner in jingle/, remoting/
avi: Owner in content/

[Avi (use Gerrit), 2013-03-05 18:45:01]

content changes lgtm

[Sergey Ulanov, 2013-03-05 20:32:57]

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:616: 'target_name': 'libpeer',
Why not call it libpeerconnection?

[Ronghua Wu (Left Chromium), 2013-03-05 20:37:15]

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:579: #
https://connect.microsoft.com/VisualStudio/feedback/details/368272/duplicate-...
make a comment this is now for the android.

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:753:
'<(libjingle_source)/talk/session/tunnel/tunnelsessionclient.h',
Do we need those 4 files in chrome build?

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:757: 'defines': [ 'LIBPEER_DLL=1' ],
you've defined this in target_defaults, do you need to define again?

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:762: '-liphlpapi.lib',
is this correct for all the platforms? i.g. .a on linux?

[tommi (sloooow) - chröme, 2013-03-05 21:29:10]

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:579: #
https://connect.microsoft.com/VisualStudio/feedback/details/368272/duplicate-...
On 2013/03/05 20:37:16, Ronghua Wu wrote:
> make a comment this is now for the android.

Done.

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:616: 'target_name': 'libpeer',
On 2013/03/05 20:32:57, sergeyu wrote:
> Why not call it libpeerconnection? 

Done.

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:753:
'<(libjingle_source)/talk/session/tunnel/tunnelsessionclient.h',
On 2013/03/05 20:37:16, Ronghua Wu wrote:
> Do we need those 4 files in chrome build?

Yes, these are used by chrome.  The difference is that they're now in the
libpeerconnection lib along with other session/media files.

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:757: 'defines': [ 'LIBPEER_DLL=1' ],
On 2013/03/05 20:37:16, Ronghua Wu wrote:
> you've defined this in target_defaults, do you need to define again?
No. Thanks for catching that.  I've removed it from target_defaults, renamed
this constant to LIBPEERCONNECTION_IMPLEMENTATION and added a comment that
explains what it's for ('dll' was confusing).

https://codereview.chromium.org/12465002/diff/8/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:762: '-liphlpapi.lib',
On 2013/03/05 20:37:16, Ronghua Wu wrote:
> is this correct for all the platforms? i.g. .a on linux?

Thanks again for catching! (I need sleep)  I added a second check for
win+shared_lib.

[Ronghua Wu (Left Chromium), 2013-03-05 22:12:02]

libjingle.gyp LGTM

[Sergey Ulanov, 2013-03-05 22:12:03]

lgtm

https://codereview.chromium.org/12465002/diff/11001/third_party/libjingle/lib...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12465002/diff/11001/third_party/libjingle/lib...
third_party/libjingle/libjingle.gyp:618: 'defines': [ 'LIBPEER_LIB=1' ],
I think since you renamed the target, it's better to rename this define as well,
i.e. it should be LIBPEERCONNECTION_LIB.

[tommi (sloooow) - chröme, 2013-03-05 22:45:52]

https://codereview.chromium.org/12465002/diff/11001/third_party/libjingle/lib...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12465002/diff/11001/third_party/libjingle/lib...
third_party/libjingle/libjingle.gyp:618: 'defines': [ 'LIBPEER_LIB=1' ],
On 2013/03/05 22:12:03, sergeyu wrote:
> I think since you renamed the target, it's better to rename this define as
well,
> i.e. it should be LIBPEERCONNECTION_LIB.

Done.  I'm having problems with git cl upload though. Any hints (the master
branch is synced to head)?

d:\src\src>git cl upload "Rename macro"
Using 50% similarity for rename/copy detection. Override with --similarity.
fatal: Needed a single revision
Command "git rev-parse --verify Rename macro" failed.