Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1246463002: Make FileSystemDirURLRequestJobTest locale-invulnerable (Closed)

Created:
5 years, 5 months ago by Tomasz Moniuszko
Modified:
5 years, 5 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FileSystemDirURLRequestJobTest locale-invulnerable The format of the date in directory listing entry depends on the current locale. In some countries (for example Poland) DD.mm.YYYY format is used. base::Time::FromString() internally uses PR_ParseTimeString() from NSPR library which doesn't support this format (date with dots as separators). Use icu::DateFormat instead which is able to parse such kind of date format. BUG= Committed: https://crrev.com/d20733a2d4a1ead1db7d9175fcaa789d33f93082 Cr-Commit-Position: refs/heads/master@{#340050}

Patch Set 1 #

Patch Set 2 : Use createDateTimeInstance() + initialize status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Tomasz Moniuszko
5 years, 5 months ago (2015-07-17 13:09:39 UTC) #2
tzik
lgtm
5 years, 5 months ago (2015-07-21 04:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246463002/1
5 years, 5 months ago (2015-07-21 06:39:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/111793)
5 years, 5 months ago (2015-07-21 06:51:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246463002/20001
5 years, 5 months ago (2015-07-22 12:06:35 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-22 12:36:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1246463002/20001
5 years, 5 months ago (2015-07-23 07:14:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 07:19:37 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 07:20:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d20733a2d4a1ead1db7d9175fcaa789d33f93082
Cr-Commit-Position: refs/heads/master@{#340050}

Powered by Google App Engine
This is Rietveld 408576698