Source/core/frame/FrameView.cpp - Issue 1246363002: Avoid updating compositor animations in hitTest path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1246363002: Avoid updating compositor animations in hitTest path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix the bug in another method Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index d636f5a92193628c3566f76d3d61a829585ff524..5130b19cde5c7d1902e0a9eee2ac43e061fddee1 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -2459,7 +2459,7 @@ void FrameView::updateLifecycleToCompositingCleanPlusScrolling()

frame().localFrameRoot()->view()->updateStyleAndLayoutIfNeededRecursive();

LayoutView* view = layoutView();

if (view)

- view->compositor()->updateIfNeededRecursive();

qiankun 2015/08/14 09:40:46 I agree with esprehn that this fix has issues espr

+ view->compositor()->updateLifecycleToCompositingClean();

scrollContentsIfNeededRecursive();

ASSERT(lifecycle().state() >= DocumentLifecycle::CompositingClean);

« no previous file with comments | « no previous file | Source/core/layout/compositing/DeprecatedPaintLayerCompositor.h » ('j') | no next file with comments »