Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1246363002: Avoid updating compositor animations in hitTest path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: revert advancing lifecycle to CompositingClean prior to hit testing Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1597 matching lines...) Expand 10 before | Expand all | Expand 10 after
1608 // transformState.m_accumulatedTransform holds the transform from the containing flattening layer. 1608 // transformState.m_accumulatedTransform holds the transform from the containing flattening layer.
1609 // transformState.m_lastPlanarPoint is the hitTestLocation in the plane of the c ontaining flattening layer. 1609 // transformState.m_lastPlanarPoint is the hitTestLocation in the plane of the c ontaining flattening layer.
1610 // transformState.m_lastPlanarQuad is the hitTestRect as a quad in the plane of the containing flattening layer. 1610 // transformState.m_lastPlanarQuad is the hitTestRect as a quad in the plane of the containing flattening layer.
1611 // 1611 //
1612 // If zOffset is non-null (which indicates that the caller wants z offset inform ation), 1612 // If zOffset is non-null (which indicates that the caller wants z offset inform ation),
1613 // *zOffset on return is the z offset of the hit point relative to the containi ng flattening layer. 1613 // *zOffset on return is the z offset of the hit point relative to the containi ng flattening layer.
1614 DeprecatedPaintLayer* DeprecatedPaintLayer::hitTestLayer(DeprecatedPaintLayer* r ootLayer, DeprecatedPaintLayer* containerLayer, HitTestResult& result, 1614 DeprecatedPaintLayer* DeprecatedPaintLayer::hitTestLayer(DeprecatedPaintLayer* r ootLayer, DeprecatedPaintLayer* containerLayer, HitTestResult& result,
1615 const LayoutRect& hitTestRect, const HitTestLocation& hitTestLocation, bool appliedTransform, 1615 const LayoutRect& hitTestRect, const HitTestLocation& hitTestLocation, bool appliedTransform,
1616 const HitTestingTransformState* transformState, double* zOffset) 1616 const HitTestingTransformState* transformState, double* zOffset)
1617 { 1617 {
1618 ASSERT(layoutObject()->document().lifecycle().state() >= DocumentLifecycle:: CompositingClean);
1619
1620 if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant()) 1618 if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant())
1621 return 0; 1619 return 0;
1622 1620
1623 ClipRectsCacheSlot clipRectsCacheSlot = result.hitTestRequest().ignoreClippi ng() ? RootRelativeClipRectsIgnoringViewportClip : RootRelativeClipRects; 1621 ClipRectsCacheSlot clipRectsCacheSlot = result.hitTestRequest().ignoreClippi ng() ? RootRelativeClipRectsIgnoringViewportClip : RootRelativeClipRects;
1624 1622
1625 // Apply a transform if we have one. 1623 // Apply a transform if we have one.
1626 if (transform() && !appliedTransform) { 1624 if (transform() && !appliedTransform) {
1627 if (enclosingPaginationLayer()) 1625 if (enclosingPaginationLayer())
1628 return hitTestTransformedLayerInFragments(rootLayer, containerLayer, result, hitTestRect, hitTestLocation, transformState, zOffset, clipRectsCacheSl ot); 1626 return hitTestTransformedLayerInFragments(rootLayer, containerLayer, result, hitTestRect, hitTestLocation, transformState, zOffset, clipRectsCacheSl ot);
1629 1627
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
2671 2669
2672 void showLayerTree(const blink::LayoutObject* layoutObject) 2670 void showLayerTree(const blink::LayoutObject* layoutObject)
2673 { 2671 {
2674 if (!layoutObject) { 2672 if (!layoutObject) {
2675 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2673 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2676 return; 2674 return;
2677 } 2675 }
2678 showLayerTree(layoutObject->enclosingLayer()); 2676 showLayerTree(layoutObject->enclosingLayer());
2679 } 2677 }
2680 #endif 2678 #endif
OLDNEW
« Source/core/frame/FrameView.cpp ('K') | « Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698