Avoid updating compositor animations in hitTest path

Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #include "core/layout/compositing/DeprecatedPaintLayerCompositor.h"
 
 #include "core/animation/AnimationTimeline.h"
-#include "core/animation/DocumentAnimations.h"
 #include "core/dom/DOMNodeIds.h"
 #include "core/dom/Fullscreen.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/layout/LayoutPart.h"
@@ skipping 183 matching lines @@
         updateDescendantDependentFlagsForEntireSubtree(*rootLayer());
         m_needsUpdateDescendantDependentFlags = false;
     }
 
     m_layoutView.commitPendingSelection();
 
     lifecycle().advanceTo(DocumentLifecycle::InCompositingUpdate);
     updateIfNeeded();
     lifecycle().advanceTo(DocumentLifecycle::CompositingClean);
 
-    DocumentAnimations::updateCompositorAnimations(m_layoutView.document());
-
-    m_layoutView.frameView()->scrollableArea()->updateCompositorScrollAnimations();
-    if (const FrameView::ScrollableAreaSet* animatingScrollableAreas = m_layoutView.frameView()->animatingScrollableAreas()) {
-        for (ScrollableArea* scrollableArea : *animatingScrollableAreas)
-            scrollableArea->updateCompositorScrollAnimations();
-    }
-

[qiankun, 2015/07/24 10:57:08]

Move these code out of updateIfNeededRecursive will make subFrame don't update
animation. There are some layout tests failure . I added a new function for hit
test path. The new function is same as updateIfNeededRecursive except no
animation update. What do you think about it?

I tried to make updateCompositorAnimations not a no-op when called twice, but
didn't get a good solution. Feel free to take over the bug, if you have a good
solution.

 #if ENABLE(ASSERT)
     ASSERT(lifecycle().state() == DocumentLifecycle::CompositingClean);
     assertNoUnresolvedDirtyBits();
     for (Frame* child = m_layoutView.frameView()->frame().tree().firstChild(); child; child = child->tree().nextSibling()) {
         if (child->isLocalFrame())
             toLocalFrame(child)->contentLayoutObject()->compositor()->assertNoUnresolvedDirtyBits();
     }
 #endif
 }
 
@@ skipping 953 matching lines @@
     } else if (graphicsLayer == m_scrollLayer.get()) {
         name = "LocalFrame Scrolling Layer";
     } else {
         ASSERT_NOT_REACHED();
     }
 
     return name;
 }
 
 } // namespace blink