Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Issue 12463031: Android WebView: don't specify cpu-specific cflags. (Closed)

Created:
7 years, 9 months ago by Torne
Modified:
7 years, 9 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews
Visibility:
Public.

Description

Android WebView: don't specify cpu-specific cflags. The WebView build gets its cpu-specific flags from the Android build system's current target; specifying them in gyp just causes conflicts, so don't bother. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188122

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase after other CL removed obsolete flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/common.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
7 years, 9 months ago (2013-03-13 12:09:59 UTC) #1
benm (inactive)
https://codereview.chromium.org/12463031/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12463031/diff/1/build/common.gypi#newcode2768 build/common.gypi:2768: 'cflags!': [ '-Wa,-mimplicit-it=thumb' ], do we also want to ...
7 years, 9 months ago (2013-03-14 11:19:24 UTC) #2
Torne
https://codereview.chromium.org/12463031/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12463031/diff/1/build/common.gypi#newcode2768 build/common.gypi:2768: 'cflags!': [ '-Wa,-mimplicit-it=thumb' ], On 2013/03/14 11:19:24, benm wrote: ...
7 years, 9 months ago (2013-03-14 11:35:15 UTC) #3
Torne
OK, I landed https://codereview.chromium.org/12412022/ to remove the -mimplicit-it flag entirely as it's obsolete, so this ...
7 years, 9 months ago (2013-03-14 15:54:04 UTC) #4
benm (inactive)
lgtm
7 years, 9 months ago (2013-03-14 17:30:20 UTC) #5
Torne
7 years, 9 months ago (2013-03-14 17:46:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r188122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698