chrome/common/extensions/permissions/api_permission.cc - Issue 12463015: Enable <adview> tag for packaged apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/api_permission.cc

Issue 12463015: Enable <adview> tag for packaged apps. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Address asargent@ code review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/api_permission.cc

diff --git a/chrome/common/extensions/permissions/api_permission.cc b/chrome/common/extensions/permissions/api_permission.cc

index 78a861ee077ef2941c0cf7a01c27c0184721e881..929b54cd3a7269338221b3a93c2f4610954c1703 100644

--- a/chrome/common/extensions/permissions/api_permission.cc

+++ b/chrome/common/extensions/permissions/api_permission.cc

@@ -195,6 +195,7 @@ void APIPermissionInfo::RegisterAllPermissions(

// Register extension permissions.

{ APIPermission::kActiveTab, "activeTab" },

+ { APIPermission::kAdView, "adview", kFlagCannotBeOptional },

{ APIPermission::kAlarms, "alarms" },

{ APIPermission::kBookmark, "bookmarks", kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,