Disable partial swaps for webview guest renderer until we can figure out how to do that properly.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 667 matching lines @@
     opener_id_ = params->opener_id;
 
   // Ensure we start with a valid next_page_id_ from the browser.
   DCHECK_GE(next_page_id_, 0);
 
 #if defined(ENABLE_NOTIFICATIONS)
   notification_provider_ = new NotificationProvider(this);
 #else
   notification_provider_ = NULL;
 #endif
+  renderer_preferences_.allow_partial_swap =
+      params->renderer_prefs.allow_partial_swap;

[alexst (slow to review), 2013/03/07 00:33:41]

This needs to be set here because OnSetRendererPrefs relies on webwidget_ being
initialized, and we need to know if we are partially swapping during webwidget_
initialization.

[jamesr, 2013/03/07 00:48:06]

Hmmmm, this is getting quite tricky.  Why don't you just set this in the
constructor?

Rather than being a RendererPreference that's actually slightly magical, what
about making this a CreateWindow_Params member and putting it explicitly in the
RenderViewImplParams struct?

 
   webwidget_ = WebView::create(this);
   webwidget_mouse_lock_target_.reset(new WebWidgetLockTarget(webwidget_));
 
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
 
 #if defined(OS_ANDROID)
   content::DeviceTelephonyInfo device_info;
 
   const std::string region_code =
@@ skipping 5580 matching lines @@
 }
 
 void RenderViewImpl::InstrumentWillComposite() {
   if (!webview())
     return;
   if (!webview()->devToolsAgent())
     return;
   webview()->devToolsAgent()->willComposite();
 }
 
+bool RenderViewImpl::AllowPartialSwap() const {
+  return renderer_preferences_.allow_partial_swap;
+}
+
 #if defined(OS_WIN)
 void RenderViewImpl::PluginFocusChanged(bool focused, int plugin_id) {
   if (focused)
     focused_plugin_id_ = plugin_id;
   else
     focused_plugin_id_ = -1;
 }
 #endif
 
 #if defined(OS_MACOSX)
@@ skipping 449 matching lines @@
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 void RenderViewImpl::DidCommitCompositorFrame() {
   RenderWidget::DidCommitCompositorFrame();
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidCommitCompositorFrame());
 }
 
 }  // namespace content