Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 1246283003: Split out audio debug recording from RenderProcessHostImpl. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_audio_processor.cc ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index a23d03e8e718641f9ef33ffca8f9993e5c5a4282..53e86065ce8da8a036f0b984228b31dceac895ad 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -15,6 +15,7 @@
#include "base/path_service.h"
#include "base/time/time.h"
#include "build/build_config.h"
+#include "content/common/mojo/service_registry_impl.h"
#include "content/public/common/media_stream_request.h"
#include "content/renderer/media/media_stream_audio_processor.h"
#include "content/renderer/media/media_stream_audio_processor_options.h"
@@ -484,14 +485,14 @@ TEST_F(MediaStreamAudioProcessorTest, MAYBE_TestAllSampleRates) {
audio_processor = NULL;
}
-// Test that if we have an AEC dump message filter created, we are getting it
+// Test that if we have an audio debug recorder created, we are getting it
// correctly in MSAP. Any IPC messages will be deleted since no sender in the
// filter will be created.
-TEST_F(MediaStreamAudioProcessorTest, GetAecDumpMessageFilter) {
+TEST_F(MediaStreamAudioProcessorTest, GetAudioDebugRecorder) {
base::MessageLoopForUI message_loop;
- scoped_refptr<AecDumpMessageFilter> aec_dump_message_filter_(
- new AecDumpMessageFilter(message_loop.task_runner(),
- message_loop.task_runner(), nullptr));
+ ServiceRegistryImpl service_registry;
+ scoped_refptr<AudioDebugRecorder> audio_debug_recorder(
+ new AudioDebugRecorder(&service_registry));
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
@@ -501,7 +502,8 @@ TEST_F(MediaStreamAudioProcessorTest, GetAecDumpMessageFilter) {
constraint_factory.CreateWebMediaConstraints(), input_device_params_,
webrtc_audio_device.get()));
- EXPECT_TRUE(audio_processor->aec_dump_message_filter_.get());
+ EXPECT_TRUE(audio_processor->audio_debug_recorder_.get());
+ EXPECT_EQ(audio_debug_recorder, audio_processor->audio_debug_recorder_);
audio_processor = NULL;
}
« no previous file with comments | « content/renderer/media/media_stream_audio_processor.cc ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698