Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246203003: Add Windows 10 support to GPU config parser. (Closed)

Created:
5 years, 5 months ago by Will Harris
Modified:
5 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Windows 10 support to GPU config parser. BUG=508746 TEST=gpu_unittests Committed: https://crrev.com/0355eead6c2048131771feb493187f6f80155cf6 Cr-Commit-Position: refs/heads/master@{#339832}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M gpu/config/gpu_test_config.h View 2 chunks +2 lines, -1 line 0 comments Download
M gpu/config/gpu_test_config.cc View 2 chunks +3 lines, -0 lines 1 comment Download
M gpu/config/gpu_test_expectations_parser.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Will Harris
PTAL looks like angle needs some of this too, which I can do in a ...
5 years, 5 months ago (2015-07-22 01:11:28 UTC) #2
Will Harris
https://codereview.chromium.org/1246203003/diff/1/gpu/config/gpu_test_config.cc File gpu/config/gpu_test_config.cc (right): https://codereview.chromium.org/1246203003/diff/1/gpu/config/gpu_test_config.cc#newcode42 gpu/config/gpu_test_config.cc:42: if (major_version == 10) this won't catch some early ...
5 years, 5 months ago (2015-07-22 01:12:35 UTC) #3
Ken Russell (switch to Gerrit)
LGTM. +zmo for any comment.
5 years, 5 months ago (2015-07-22 01:37:57 UTC) #5
Zhenyao Mo
LGTM
5 years, 5 months ago (2015-07-22 02:45:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246203003/1
5 years, 5 months ago (2015-07-22 03:12:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 04:15:08 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 04:15:58 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0355eead6c2048131771feb493187f6f80155cf6
Cr-Commit-Position: refs/heads/master@{#339832}

Powered by Google App Engine
This is Rietveld 408576698