Issue 12462002: Wait for sweeper threads in EnsureSweeperProgress() only if the main thread finished its sweeping p…

Issue 12462002: Wait for sweeper threads in EnsureSweeperProgress() only if the main thread finished its sweeping p… (Closed)

Created:
7 years, 9 months ago by Hannes Payer (out of office)

Modified:
7 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Wait for sweeper threads in EnsureSweeperProgress() only if the main thread finished its sweeping phase. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13830

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -7 lines)			Patch
M	src/mark-compact.h	View	1 2	3 chunks	+26 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/spaces.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/spaces.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with two comments. https://codereview.chromium.org/12462002/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/12462002/diff/2001/src/mark-compact.cc#newcode3899 src/mark-compact.cc:3899: { SweepingScope scope(this); Since the ...

7 years, 9 months ago (2013-03-05 17:20:11 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/12462002/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/12462002/diff/2001/src/mark-compact.cc#newcode3899 src/mark-compact.cc:3899: { SweepingScope scope(this); On 2013/03/05 17:20:11, Michael Starzinger wrote: ...

7 years, 9 months ago (2013-03-05 17:27:04 UTC) #3

Hannes Payer (out of office)

7 years, 9 months ago (2013-03-05 17:32:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r13830 (presubmit successful).

Expand Messages | Collapse Messages