Issue 1246183002: testing: No need to handle direct_dependent_configs in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1246183002: testing: No need to handle direct_dependent_configs in GN build. (Closed)

Created:
5 years, 5 months ago by tfarina

Modified:
5 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

testing: No need to handle direct_dependent_configs in GN build. direct_dependent_configs is the deprecated name for public_configs, and public_configs is already handled. gn-dev thread: https://groups.google.com/a/chromium.org/d/topic/gn-dev/h9N85MIx_Bk/discussion BUG=None TEST=gn gen out-gn/Debug R=brettw@chromium.org Committed: https://crrev.com/e1508bdddadf8676d7d75d71958ae16d88d0c506 Cr-Commit-Position: refs/heads/master@{#339797}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	testing/test.gni	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246183002/20001

5 years, 5 months ago (2015-07-22 00:15:33 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 00:22:48 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e1508bdddadf8676d7d75d71958ae16d88d0c506
Cr-Commit-Position: refs/heads/master@{#339797}