Throttle rendering pipeline for invisible iframes

Source/core/page/PageAnimator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/page/PageAnimator.h"
 
 #include "core/animation/DocumentAnimations.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 21 matching lines @@
     visitor->trace(m_page);
 }
 
 void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
 {
     RefPtrWillBeRawPtr<PageAnimator> protector(this);
     TemporaryChange<bool> servicing(m_servicingAnimations, true);
 
     WillBeHeapVector<RefPtrWillBeMember<Document>> documents;
     for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
-        if (frame->isLocalFrame())
-            documents.append(toLocalFrame(frame)->document());
+        if (!frame->isLocalFrame())
+            continue;
+        LocalFrame* localFrame = toLocalFrame(frame);
+        // FIXME: Keep the animation timing ticking while throttled.

[esprehn, 2015/09/02 21:10:37]

I don't think you need to do anything special here, the animation system should
be able to do an on demand update?

[Sami, 2015/09/03 17:23:20]

This is referring to dstockwell@'s earlier comment about making sure the
animation time remains valid if someone queries for it
(DocumentAnimations::updateAnimationTimingForAnimationFrame) but still avoiding
any other animation related processing.

+        if (localFrame->shouldThrottleRenderingPipeline())
+            continue;
+        documents.append(localFrame->document());
     }
 
     for (auto& document : documents) {
         if (document->view()) {
             document->view()->scrollableArea()->serviceScrollAnimations(monotonicAnimationStartTime);
 
             if (const FrameView::ScrollableAreaSet* animatingScrollableAreas = document->view()->animatingScrollableAreas()) {
                 // Iterate over a copy, since ScrollableAreas may deregister
                 // themselves during the iteration.
                 Vector<ScrollableArea*> animatingScrollableAreasCopy;
@@ skipping 30 matching lines @@
 }
 
 void PageAnimator::updateLayoutAndStyleForPainting(LocalFrame* rootFrame)
 {
     RefPtrWillBeRawPtr<FrameView> view = rootFrame->view();
 
     TemporaryChange<bool> servicing(m_updatingLayoutAndStyleForPainting, true);
 
     // setFrameRect may have the side-effect of causing existing page layout to
     // be invalidated, so layout needs to be called last.
-    view->updateAllLifecyclePhases();
+    view->updateAllLifecyclePhases(FrameView::LifecycleThrottlingMode::Allow);

[esprehn, 2015/09/02 21:10:37]

Lets un-nest the enum.

[Sami, 2015/09/03 17:23:20]

Done.

 }
 
 }