Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1246133002: [NaCl SDK] Fix bionic SDK build (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix bionic SDK build This was broken by my recent change to enable arm-glibc. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk Committed: https://crrev.com/eacd62ffa6f8b29c9f2ce87ef3076d4e969b177a Cr-Commit-Position: refs/heads/master@{#339773}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Sam Clegg
5 years, 5 months ago (2015-07-21 20:53:12 UTC) #2
bradn
lgtm
5 years, 5 months ago (2015-07-21 20:53:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246133002/20001
5 years, 5 months ago (2015-07-21 20:54:33 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 21:04:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246133002/20001
5 years, 5 months ago (2015-07-21 21:07:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 23:05:35 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 23:06:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eacd62ffa6f8b29c9f2ce87ef3076d4e969b177a
Cr-Commit-Position: refs/heads/master@{#339773}

Powered by Google App Engine
This is Rietveld 408576698