build/config/compiler/BUILD.gn - Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index e006f3bdaa54c5ef751747c615d17735c30f9ed6..b578b210823f47f52e4efbf15e6be999e36fb568 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -723,11 +723,6 @@ if (is_win) {

default_warning_flags += [

# Warnings permanently disabled:

- # TODO(GYP) The GYP build doesn't have this globally enabled but disabled

- # for a bunch of individual targets. Re-enable this globally when those

- # targets are fixed.

- "/wd4018", # Comparing signed and unsigned values.

# C4127: conditional expression is constant

# This warning can in theory catch dead code and other problems, but

# triggers in far too many desirable cases where the conditional

« no previous file with comments | « no previous file | components/filesystem/file_impl.cc » ('j') | no next file with comments »