Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1246103003: Sandbox: store RestrictedToken::effective_token_ on a ScopedHandle. (Closed)

Created:
5 years, 5 months ago by rvargas (doing something else)
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: store RestrictedToken::effective_token_ on a ScopedHandle. BUG=426577 Committed: https://crrev.com/f8d94bd509dbca9bbc1395aed3f8390a1b3c85d0 Cr-Commit-Position: refs/heads/master@{#339758}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix enum name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -127 lines) Patch
M sandbox/win/src/restricted_token.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/restricted_token.cc View 1 13 chunks +75 lines, -126 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rvargas (doing something else)
ptal
5 years, 5 months ago (2015-07-21 20:50:16 UTC) #2
rvargas (doing something else)
https://codereview.chromium.org/1246103003/diff/1/sandbox/win/src/restricted_token.cc File sandbox/win/src/restricted_token.cc (right): https://codereview.chromium.org/1246103003/diff/1/sandbox/win/src/restricted_token.cc#newcode19 sandbox/win/src/restricted_token.cc:19: _TOKEN_INFORMATION_CLASS info_class, will remove the underscore.
5 years, 5 months ago (2015-07-21 20:52:53 UTC) #3
Will Harris
lgtm
5 years, 5 months ago (2015-07-21 21:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246103003/20001
5 years, 5 months ago (2015-07-21 21:26:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 22:05:04 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 22:05:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8d94bd509dbca9bbc1395aed3f8390a1b3c85d0
Cr-Commit-Position: refs/heads/master@{#339758}

Powered by Google App Engine
This is Rietveld 408576698