relnote: Protect against a QUIC crash bug but logging a DFATAL and

relnote: Protect against a QUIC crash bug but logging a DFATAL and
closing the connection instead when a packet cannot be serialized.

This could help fixing Chromium BUG=479880
. Will land after
https://codereview.chromium.org/1247563002/ is committed.

Merge internal change: 98506577
R=rch@chromium.org
BUG=479880, 512446
Committed: https://crrev.com/8811fdb4eb5400198d68f05f7a47c8724a13c628
Cr-Commit-Position: refs/heads/master@{#339794}

[ramant (doing other things), 2015-07-21 20:59:03]

On 2015/07/21 20:58:03, ramant wrote:

This CL is same as https://codereview.chromium.org/1246793002/ (which was
reverted).

[Ryan Hamilton, 2015-07-21 21:44:59]

lgtm

[ramant (doing other things), 2015-07-21 22:05:13]

On 2015/07/21 21:44:59, Ryan Hamilton wrote:
> lgtm

Trying linux_chromium_chromeos_dbg_ng, linux_chromium_chromeos_rel_ng,
linux_chromium_gn_chromeos_dbg  try bots.

[Nico, 2015-07-21 22:12:23]

On 2015/07/21 22:05:13, ramant wrote:
> On 2015/07/21 21:44:59, Ryan Hamilton wrote:
> > lgtm
> 
> Trying linux_chromium_chromeos_dbg_ng, linux_chromium_chromeos_rel_ng,
> linux_chromium_gn_chromeos_dbg  try bots.

(i don't know if we have any trybots that run tests in official build configs.
if you haven't, try to test that config locally)

[ramant (doing other things), 2015-07-22 00:09:42]

On 2015/07/21 22:12:23, Nico (hiding) wrote:
> On 2015/07/21 22:05:13, ramant wrote:
> > On 2015/07/21 21:44:59, Ryan Hamilton wrote:
> > > lgtm
> > 
> > Trying linux_chromium_chromeos_dbg_ng, linux_chromium_chromeos_rel_ng,
> > linux_chromium_gn_chromeos_dbg  try bots.
> 
> (i don't know if we have any trybots that run tests in official build configs.
> if you haven't, try to test that config locally)

I know the problem. Any unit test, which tests LOG(DFATAL) could have an
issue in the following case.

If we call  LOG(DFATAL), followed by CHECK, it crashes on some platforms
for unit tests (which do EXPECT_DFATAL) and on some platforms it doesn't. 

This CL worked on all try bots and Release build (because we reverted
CHECK change).

[ramant (doing other things), 2015-07-22 00:09:45]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-07-22 00:10:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246093003/1

[commit-bot: I haz the power, 2015-07-22 00:17:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-22 00:18:20]

Patchset 1 (id:??) landed as
https://crrev.com/8811fdb4eb5400198d68f05f7a47c8724a13c628
Cr-Commit-Position: refs/heads/master@{#339794}