Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246053003: Renames html_viewer frame classes (Closed)

Created:
5 years, 5 months ago by sky
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames html_viewer frame classes To avoid confusion with the ones in mandoline I'm renaming the html_viewer to be prefixed with html_. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/cce531ce2d0797205a749cc13b701d882334dec8 Cr-Commit-Position: refs/heads/master@{#339745}

Patch Set 1 #

Patch Set 2 : really rename #

Patch Set 3 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -1345 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/html_viewer/frame.h View 1 chunk +0 lines, -213 lines 0 comments Download
D components/html_viewer/frame.cc View 1 chunk +0 lines, -560 lines 0 comments Download
D components/html_viewer/frame_tree_manager.h View 1 chunk +0 lines, -123 lines 0 comments Download
D components/html_viewer/frame_tree_manager.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D components/html_viewer/frame_tree_manager_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
M components/html_viewer/html_document_oopif.h View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M components/html_viewer/html_document_oopif.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
A + components/html_viewer/html_frame.h View 1 2 7 chunks +29 lines, -27 lines 0 comments Download
A + components/html_viewer/html_frame.cc View 1 25 chunks +76 lines, -75 lines 0 comments Download
A + components/html_viewer/html_frame_tree_manager.h View 1 6 chunks +25 lines, -25 lines 0 comments Download
A + components/html_viewer/html_frame_tree_manager.cc View 1 9 chunks +47 lines, -45 lines 0 comments Download
A + components/html_viewer/html_frame_tree_manager_delegate.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M components/html_viewer/web_layer_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/web_layer_impl.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 5 months ago (2015-07-21 18:14:22 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 5 months ago (2015-07-21 20:16:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246053003/40001
5 years, 5 months ago (2015-07-21 20:22:42 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-21 21:04:46 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:05:52 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cce531ce2d0797205a749cc13b701d882334dec8
Cr-Commit-Position: refs/heads/master@{#339745}

Powered by Google App Engine
This is Rietveld 408576698