Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: media/renderers/video_renderer_impl.cc

Issue 1246033008: media: In low delay mode, do not accumulate frames earlier than the start time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/video_renderer_impl.cc
diff --git a/media/renderers/video_renderer_impl.cc b/media/renderers/video_renderer_impl.cc
index 1160b65dae5773ddcbd7bba5226c319f218543b2..01dfe37da1a344105b08146757eb9174dd44989e 100644
--- a/media/renderers/video_renderer_impl.cc
+++ b/media/renderers/video_renderer_impl.cc
@@ -490,6 +490,16 @@ void VideoRendererImpl::FrameReady(VideoFrameStream::Status status,
return;
}
+ // In low delay mode, don't accumulate frames that's earlier than the start
+ // time. Otherwise we could declare HAVE_ENOUGH_DATA and start playback
+ // prematurely.
+ if (low_delay_ &&
+ !frame->metadata()->IsTrue(VideoFrameMetadata::END_OF_STREAM) &&
+ frame->timestamp() < start_timestamp_) {
+ AttemptRead_Locked();
+ return;
+ }
+
if (frame->metadata()->IsTrue(VideoFrameMetadata::END_OF_STREAM)) {
DCHECK(!received_end_of_stream_);
received_end_of_stream_ = true;
« no previous file with comments | « no previous file | media/renderers/video_renderer_impl_unittest.cc » ('j') | media/renderers/video_renderer_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698