Run noise shader separately in imagefiltersclipped

Run noise shader separately in imagefiltersclipped

BUG=skia:4079
Committed: https://skia.googlesource.com/skia/+/02781977e00d88a7b0a3bbd6de158a9f3fecfd46

[jvanverth1, 2015-07-21 14:22:16]

jvanverth@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[jvanverth1, 2015-07-21 14:22:16]

Running all of these filters at once seems to be overwhelming the S4. If I run
the Perlin noise shader + rect filter separately, gm completes.

[robertphillips, 2015-07-21 14:38:42]

lgtm + suggestions & a leak

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp
File gm/imagefiltersclipped.cpp (right):

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp#...
gm/imagefiltersclipped.cpp:130: 
leak?
Mv 'noise' down here too?

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp#...
gm/imagefiltersclipped.cpp:133: for (int xOffset = 0; xOffset < 80; xOffset +=
16) {
Would it be clearer if this were a subroutine:

draw(canvas, clipRect/bounds, filter)

?

[jvanverth1, 2015-07-21 15:30:37]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-07-21 15:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1245983002/#ps20001
(title: "Address comments")

[jvanverth1, 2015-07-21 15:30:45]

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp
File gm/imagefiltersclipped.cpp (right):

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp#...
gm/imagefiltersclipped.cpp:130: 
On 2015/07/21 14:38:41, robertphillips wrote:
> leak?
> Mv 'noise' down here too?

Done.

https://codereview.chromium.org/1245983002/diff/1/gm/imagefiltersclipped.cpp#...
gm/imagefiltersclipped.cpp:133: for (int xOffset = 0; xOffset < 80; xOffset +=
16) {
On 2015/07/21 14:38:42, robertphillips wrote:
> Would it be clearer if this were a subroutine:
> 
> draw(canvas, clipRect/bounds, filter)
> 
> ?

Done.

[commit-bot: I haz the power, 2015-07-21 15:30:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245983002/20001

[commit-bot: I haz the power, 2015-07-21 15:38:08]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/02781977e00d88a7b0a3bbd6de158a9f3fecfd46