src/heap-inl.h - Issue 12459026: ES6 symbols: implement name property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 12459026: ES6 symbols: implement name property (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index 9ed65d8107ddc04a38e72b61c1002c483562bcf4..a15b8ef489ef4ad9663ba174ae0798a2c76b3b04 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -399,7 +399,9 @@ AllocationSpace Heap::TargetSpaceId(InstanceType type) {

ASSERT(type != ODDBALL_TYPE);

ASSERT(type != JS_GLOBAL_PROPERTY_CELL_TYPE);

- if (type < FIRST_NONSTRING_TYPE) {

+ if (type <= LAST_NAME_TYPE) {

+ if (type == SYMBOL_TYPE) return OLD_POINTER_SPACE;

+ ASSERT(type < FIRST_NONSTRING_TYPE);

// There are four string representations: sequential strings, external

// strings, cons strings, and sliced strings.

// Only the latter two contain non-map-word pointers to heap objects.

« no previous file with comments | « src/heap.cc ('k') | src/log.cc » ('j') | no next file with comments »