Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: src/objects.cc

Issue 12459026: ES6 symbols: implement name property (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1442 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 else if (IsNull()) 1453 else if (IsNull())
1454 accumulator->Add("<null>"); 1454 accumulator->Add("<null>");
1455 else if (IsTrue()) 1455 else if (IsTrue())
1456 accumulator->Add("<true>"); 1456 accumulator->Add("<true>");
1457 else if (IsFalse()) 1457 else if (IsFalse())
1458 accumulator->Add("<false>"); 1458 accumulator->Add("<false>");
1459 else 1459 else
1460 accumulator->Add("<Odd Oddball>"); 1460 accumulator->Add("<Odd Oddball>");
1461 break; 1461 break;
1462 } 1462 }
1463 case SYMBOL_TYPE: 1463 case SYMBOL_TYPE: {
1464 accumulator->Add("<Symbol: %d>", Symbol::cast(this)->Hash()); 1464 Symbol* symbol = Symbol::cast(this);
1465 accumulator->Add("<Symbol: %d", symbol->Hash());
1466 if (!symbol->name()->IsUndefined()) {
1467 accumulator->Add(" ");
1468 String::cast(symbol->name())->StringShortPrint(accumulator);
1469 }
1470 accumulator->Add(">");
1465 break; 1471 break;
1472 }
1466 case HEAP_NUMBER_TYPE: 1473 case HEAP_NUMBER_TYPE:
1467 accumulator->Add("<Number: "); 1474 accumulator->Add("<Number: ");
1468 HeapNumber::cast(this)->HeapNumberPrint(accumulator); 1475 HeapNumber::cast(this)->HeapNumberPrint(accumulator);
1469 accumulator->Put('>'); 1476 accumulator->Put('>');
1470 break; 1477 break;
1471 case JS_PROXY_TYPE: 1478 case JS_PROXY_TYPE:
1472 accumulator->Add("<JSProxy>"); 1479 accumulator->Add("<JSProxy>");
1473 break; 1480 break;
1474 case JS_FUNCTION_PROXY_TYPE: 1481 case JS_FUNCTION_PROXY_TYPE:
1475 accumulator->Add("<JSFunctionProxy>"); 1482 accumulator->Add("<JSFunctionProxy>");
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1565 case MAP_TYPE: 1572 case MAP_TYPE:
1566 Map::BodyDescriptor::IterateBody(this, v); 1573 Map::BodyDescriptor::IterateBody(this, v);
1567 break; 1574 break;
1568 case CODE_TYPE: 1575 case CODE_TYPE:
1569 reinterpret_cast<Code*>(this)->CodeIterateBody(v); 1576 reinterpret_cast<Code*>(this)->CodeIterateBody(v);
1570 break; 1577 break;
1571 case JS_GLOBAL_PROPERTY_CELL_TYPE: 1578 case JS_GLOBAL_PROPERTY_CELL_TYPE:
1572 JSGlobalPropertyCell::BodyDescriptor::IterateBody(this, v); 1579 JSGlobalPropertyCell::BodyDescriptor::IterateBody(this, v);
1573 break; 1580 break;
1574 case SYMBOL_TYPE: 1581 case SYMBOL_TYPE:
1582 Symbol::BodyDescriptor::IterateBody(this, v);
1583 break;
1575 case HEAP_NUMBER_TYPE: 1584 case HEAP_NUMBER_TYPE:
1576 case FILLER_TYPE: 1585 case FILLER_TYPE:
1577 case BYTE_ARRAY_TYPE: 1586 case BYTE_ARRAY_TYPE:
1578 case FREE_SPACE_TYPE: 1587 case FREE_SPACE_TYPE:
1579 case EXTERNAL_PIXEL_ARRAY_TYPE: 1588 case EXTERNAL_PIXEL_ARRAY_TYPE:
1580 case EXTERNAL_BYTE_ARRAY_TYPE: 1589 case EXTERNAL_BYTE_ARRAY_TYPE:
1581 case EXTERNAL_UNSIGNED_BYTE_ARRAY_TYPE: 1590 case EXTERNAL_UNSIGNED_BYTE_ARRAY_TYPE:
1582 case EXTERNAL_SHORT_ARRAY_TYPE: 1591 case EXTERNAL_SHORT_ARRAY_TYPE:
1583 case EXTERNAL_UNSIGNED_SHORT_ARRAY_TYPE: 1592 case EXTERNAL_UNSIGNED_SHORT_ARRAY_TYPE:
1584 case EXTERNAL_INT_ARRAY_TYPE: 1593 case EXTERNAL_INT_ARRAY_TYPE:
(...skipping 12734 matching lines...) Expand 10 before | Expand all | Expand 10 after
14319 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 14328 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
14320 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 14329 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
14321 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 14330 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
14322 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 14331 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
14323 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 14332 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
14324 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 14333 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
14325 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 14334 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
14326 } 14335 }
14327 14336
14328 } } // namespace v8::internal 14337 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698