Adds muls, sdiv, udiv instructions to ARM simulator, assembler, disassembler

runtime/vm/assembler_arm_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 1405 matching lines @@
   bool have_div = CPUFeatures::integer_division_supported();
   int32_t r = EXECUTE_TEST_CODE_INT32(Tst, test->entry());
   if (have_div) {
     EXPECT_LT(0, r);
   } else {
     EXPECT_EQ(0, r);
   }
 }
 
 
+ASSEMBLER_TEST_GENERATE(Udiv, assembler) {
+  __ mov(R0, ShifterOperand(27));
+  __ mov(R1, ShifterOperand(9));
+  __ udiv(R2, R0, R1);
+  __ Mov(R0, R2);
+  __ mov(PC, ShifterOperand(LR));
+}
+
+
+ASSEMBLER_TEST_RUN(Udiv, test) {
+  EXPECT(test != NULL);
+  typedef int (*Tst)();
+  EXPECT_EQ(3, EXECUTE_TEST_CODE_INT32(Tst, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Sdiv, assembler) {
+  __ mov(R0, ShifterOperand(27));
+  __ LoadImmediate(R1, -9);
+  __ sdiv(R2, R0, R1);
+  __ Mov(R0, R2);
+  __ mov(PC, ShifterOperand(LR));
+}
+
+
+ASSEMBLER_TEST_RUN(Sdiv, test) {
+  EXPECT(test != NULL);
+  typedef int (*Tst)();
+  EXPECT_EQ(-3, EXECUTE_TEST_CODE_INT32(Tst, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Muls, assembler) {
+  __ mov(R0, ShifterOperand(3));
+  __ LoadImmediate(R1, -9);
+  __ muls(R2, R0, R1);
+  __ mov(R0, ShifterOperand(42), MI);
+  __ mov(PC, ShifterOperand(LR));
+}
+
+
+ASSEMBLER_TEST_RUN(Muls, test) {
+  EXPECT(test != NULL);
+  typedef int (*Tst)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(Tst, test->entry()));
+}

[regis, 2013/03/05 19:11:34]

I would add tests for division by zero as well as 0x80000000 / 0xFFFFFFFF ==
0x80000000. See spec. None of these should cause the host (simulator) to throw.
See my other comment. 

+
+
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM