Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 12459004: Adjust pnacl-translate sbtc flag override mechanism to append. (Closed)

Created:
7 years, 9 months ago by jvoung (off chromium)
Modified:
7 years, 9 months ago
Reviewers:
sehr, Derek Schuff, eliben
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Adjust pnacl-translate sbtc flag override mechanism to append. Separate -mcpu from the default, so that it can be overridden. Remove LLC_FLAGS_SLOW. That is considered the default right now, but it was never put into the default commandline flags in the sandboxed translator, so it's not really default anyway. Also test that the overrides actually happen (especially for the RPCs). Depends on: https://codereview.chromium.org/12459004/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=3325 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10971

Patch Set 1 #

Patch Set 2 : Add a test #

Patch Set 3 : add a test #

Patch Set 4 : test default for reals #

Total comments: 4

Patch Set 5 : cleanup #

Patch Set 6 : python 2.6 compatibility #

Patch Set 7 : make test depend on sel_* of the tested platform #

Patch Set 8 : inline func #

Patch Set 9 : disable under dbg-host #

Patch Set 10 : refine for bootstrap ldr #

Total comments: 2

Patch Set 11 : do cpu check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -45 lines) Patch
M SConstruct View 1 2 3 4 5 6 5 chunks +6 lines, -5 lines 0 comments Download
M pnacl/driver/driver_tools.py View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -1 line 0 comments Download
M pnacl/driver/pnacl-translate.py View 1 2 3 4 7 chunks +25 lines, -36 lines 0 comments Download
M pnacl/driver/tests/build.scons View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -1 line 0 comments Download
M pnacl/driver/tests/driver_test_utils.py View 1 3 chunks +13 lines, -2 lines 0 comments Download
M pnacl/driver/tests/driver_tests.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A pnacl/driver/tests/translate_options_test.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +259 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvoung (off chromium)
Test for https://codereview.chromium.org/12490004/. Sorry, the test code is a bit gross...
7 years, 9 months ago (2013-03-05 23:33:38 UTC) #1
Derek Schuff
https://codereview.chromium.org/12459004/diff/6001/pnacl/driver/pnacl-translate.py File pnacl/driver/pnacl-translate.py (right): https://codereview.chromium.org/12459004/diff/6001/pnacl/driver/pnacl-translate.py#newcode127 pnacl/driver/pnacl-translate.py:127: # These are handled separately by libLTO. this line ...
7 years, 9 months ago (2013-03-06 21:10:12 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/12459004/diff/6001/pnacl/driver/pnacl-translate.py File pnacl/driver/pnacl-translate.py (right): https://codereview.chromium.org/12459004/diff/6001/pnacl/driver/pnacl-translate.py#newcode127 pnacl/driver/pnacl-translate.py:127: # These are handled separately by libLTO. On 2013/03/06 ...
7 years, 9 months ago (2013-03-06 21:26:58 UTC) #3
Derek Schuff
lgtm
7 years, 9 months ago (2013-03-06 21:41:49 UTC) #4
jvoung (off chromium)
Ah turns out that the driver cares a lot about sel_universal and sel_ldr being built ...
7 years, 9 months ago (2013-03-12 01:40:24 UTC) #5
Derek Schuff
https://codereview.chromium.org/12459004/diff/27008/pnacl/driver/tests/translate_options_test.py File pnacl/driver/tests/translate_options_test.py (right): https://codereview.chromium.org/12459004/diff/27008/pnacl/driver/tests/translate_options_test.py#newcode144 pnacl/driver/tests/translate_options_test.py:144: expected_triple_cpu = ['-mtriple=arm.*', '-mcpu=.*'] this mcpu doesn't match what ...
7 years, 9 months ago (2013-03-12 17:13:09 UTC) #6
jvoung (off chromium)
https://codereview.chromium.org/12459004/diff/27008/pnacl/driver/tests/translate_options_test.py File pnacl/driver/tests/translate_options_test.py (right): https://codereview.chromium.org/12459004/diff/27008/pnacl/driver/tests/translate_options_test.py#newcode144 pnacl/driver/tests/translate_options_test.py:144: expected_triple_cpu = ['-mtriple=arm.*', '-mcpu=.*'] On 2013/03/12 17:13:09, Derek Schuff ...
7 years, 9 months ago (2013-03-12 18:02:02 UTC) #7
Derek Schuff
lgtm
7 years, 9 months ago (2013-03-12 18:02:17 UTC) #8
jvoung (off chromium)
7 years, 9 months ago (2013-03-12 23:45:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #11 manually as r10971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698