Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1245883005: Fix variable shadowing in SkMorphologyImageFilter (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix variable shadowing in SkMorphologyImageFilter Committed: https://skia.googlesource.com/skia/+/eb86b55fe997e1f2f902d3d5c599bf6894f0f07c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/effects/SkMorphologyImageFilter.cpp View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 5 months ago (2015-07-23 18:21:31 UTC) #2
bsalomon
lgtm
5 years, 5 months ago (2015-07-23 18:24:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245883005/1
5 years, 5 months ago (2015-07-23 18:24:47 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-23 18:33:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245883005/1
5 years, 5 months ago (2015-07-23 18:34:46 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 18:35:10 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eb86b55fe997e1f2f902d3d5c599bf6894f0f07c

Powered by Google App Engine
This is Rietveld 408576698